-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenAI o1 support #347
base: main
Are you sure you want to change the base?
OpenAI o1 support #347
Conversation
I'd like to propose adding documentation regarding o1 separately when we do the documentation updates. I think a table showing supported features and models/clients would be beneficial. |
Outstanding, if we can put documentation in a separate PR, is testing this with Here's sample code to run against this branch to test
|
LGTM. thanks @marklysze |
Co-authored-by: Chi Wang <[email protected]>
Why are these changes needed?
the o1 preview and o1 series models doesnt support the same API parameters (Limitations) as the other openai models, so added a helper function in the OpenAIClient that tackles this issue and can be run in the agentic workflow.
tested with the two agent run (with o1-preview) with a question from simple-bench, and it runs perfectly on my side.
Related issue number
Checks