Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add swarm manager option #217

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Add swarm manager option #217

merged 2 commits into from
Jan 2, 2025

Conversation

yiranwu0
Copy link
Collaborator

@yiranwu0 yiranwu0 commented Dec 16, 2024

Why are these changes needed?

Add Afterwork.SWARM_MANAGER option.

Related issue number

4 th point in Issue #193

Checks

@marklysze
Copy link
Collaborator

Thanks @yiranwu0... the auto speaker selection will also look at all agents in the underlying groupchat, and we have the tool executor agent, nested chat agents, and the user proxy agent in there. I think we need to filter out the tool executor, what do you think?

@marklysze
Copy link
Collaborator

Thanks for the chat @yiranwu0, agree we can push forward without excluding agents and consider putting in a description on the tool executor to minimise the chance of it being selected.

@qingyun-wu
Copy link
Collaborator

@yiranwu0 could you fix the conflicts! Thanks!

@marklysze
Copy link
Collaborator

Just a note that I'm adding a system message to minimise the tool executor being called by auto speaker selection in PR #316:

    tool_execution = ConversableAgent(
        name=__TOOL_EXECUTOR_NAME__,
        system_message="Tool Execution, do not use this agent directly.",
    )

So this is good to go, thanks @yiranwu0!

@marklysze marklysze added this pull request to the merge queue Jan 2, 2025
Merged via the queue into main with commit 7778696 Jan 2, 2025
211 checks passed
@marklysze
Copy link
Collaborator

@yiranwu0, I just noticed that we lost the return of "auto" for SWARM_MANAGER, so I'll add an updated PR for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants