use webvr-polyfill version that handles missing rotationRate #4548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Head orientation on stereo mode via polyfill is currently broken on latest iOS 13.4.1 Does this fix the issue? |
|
I don't know, but quite possibly - was going to suggest that on the issue and reopen it |
This was referenced Apr 14, 2020
|
This prevents the page from crashing because of the log spam, but it does not make orientation work again. And it also relies on referencing specific branches of a forked repository..to two levels. Edit: See #4554 to see what the root of the issue is. (Webkit bug) |
|
The issue has been fixed upstream in the webvr-polyfill repo thanks to @jsantell. Now merged in master. Thanks everybody for investigating |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes log spam due to missing rotationRate observed on newer iOS.
Changes proposed:
Use fixed webvr-polyfill (which in turn uses fixed cardboard-vr-display)