map to forEach, per discussion on PR

aframevr · Mar 2, 2017 · 3b8199b · 3b8199b
1 parent 096f21c
commit 3b8199b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/components/oculus-touch-controls.js b/src/components/oculus-touch-controls.js
@@ -285,13 +285,13 @@ module.exports.Component = registerComponent('oculus-touch-controls', {
     // In theory, it might be better to use mapping from axis to control.
     // In practice, it is not clear whether the additional overhead is worthwhile,
     // and if we did grouping of axes, we really need de-duplication there.
-    Object.keys(axesMapping).map(function (key) {
+    Object.keys(axesMapping).forEach(function (key) {
       var value = axesMapping[key];
       var detail = {};
       var changed = !evt.detail.changed;
-      if (!changed) { value.map(function (axisNumber) { changed |= evt.detail.changed[axisNumber]; }); }
+      if (!changed) { value.forEach(function (axisNumber) { changed |= evt.detail.changed[axisNumber]; }); }
       if (changed) {
-        value.map(function (axisNumber) { detail[self.axisLabels[axisNumber]] = evt.detail.axis[axisNumber]; });
+        value.forEach(function (axisNumber) { detail[self.axisLabels[axisNumber]] = evt.detail.axis[axisNumber]; });
         self.el.emit(key + 'moved', detail);
         // If we updated the model based on axis values, that call would go here.
       }

diff --git a/src/components/vive-controls.js b/src/components/vive-controls.js
@@ -199,13 +199,13 @@ module.exports.Component = registerComponent('vive-controls', {
     // In theory, it might be better to use mapping from axis to control.
     // In practice, it is not clear whether the additional overhead is worthwhile,
     // and if we did grouping of axes, we really need de-duplication there.
-    Object.keys(axesMapping).map(function (key) {
+    Object.keys(axesMapping).forEach(function (key) {
       var value = axesMapping[key];
       var detail = {};
       var changed = !evt.detail.changed;
-      if (!changed) { value.map(function (axisNumber) { changed |= evt.detail.changed[axisNumber]; }); }
+      if (!changed) { value.forEach(function (axisNumber) { changed |= evt.detail.changed[axisNumber]; }); }
       if (changed) {
-        value.map(function (axisNumber) { detail[self.axisLabels[axisNumber]] = evt.detail.axis[axisNumber]; });
+        value.forEach(function (axisNumber) { detail[self.axisLabels[axisNumber]] = evt.detail.axis[axisNumber]; });
         self.el.emit(key + 'moved', detail);
         // If we updated the model based on axis values, that call would go here.
       }