feat: FTL-18486 run integration tests before release (#32)

affinidi · Dec 19, 2024 · 494653e · 494653e
1 parent f59edf4
commit 494653e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 17 deletions.
diff --git a/src/Clients/IotaClient/lib/Model/FetchIOTAVPResponseOK.php b/src/Clients/IotaClient/lib/Model/FetchIOTAVPResponseOK.php
@@ -174,8 +174,8 @@ public function isNullableSetToNull(string $property): bool
      */
     protected static $attributeMap = [
         'correlation_id' => 'correlationId',
-        'presentation_submission' => 'presentation_submission',
-        'vp_token' => 'vp_token'
+        'presentation_submission' => 'presentationSubmission',
+        'vp_token' => 'vpToken'
     ];
 
     /**

diff --git a/tests/Helpers/TestHelper.php b/tests/Helpers/TestHelper.php
@@ -24,8 +24,6 @@ function getConfiguration()
         'vpToken' => $_ENV['VP_TOKEN'],
         'vc' => $_ENV['VERIFIABLE_CREDENTIAL'],
         'vcInvalid' => $_ENV['VERIFIABLE_CREDENTIAL_INVALID'],
-        'expiredJwt' => $_ENV['EXPIRED_JWT'],
-        'invalidJwt' => $_ENV['INVALID_JWT'],
         'issuanceData' => $_ENV['CREDENTIAL_ISSUANCE_DATA']
     ];
 }

diff --git a/tests/Integration/IotaClientIntegrationTest.php b/tests/Integration/IotaClientIntegrationTest.php
@@ -108,21 +108,14 @@ public function testRedirectFlow()
 
         $this->assertNotEmpty($resultJson);
 
-        // TODO: uncomment the below, once iota-service is fixed and clients are regenerated:
-        //       FetchIOTAVPResponseOK Model should have vpToken and presentationSubmission instead of vp_token and presentation_submission
-
         // // Assert that 'vpToken' key exists
-        // $this->assertArrayHasKey('vpToken', $resultJson, 'The response does not contain a "vpToken" key.');
-
-        // $vp = $resultJson['vpToken'];
-        // $vpJson = json_decode($vp, true);
+        $this->assertArrayHasKey('vpToken', $resultJson, 'The response does not contain a "vpToken" key.');
 
-        // // Assert that the count of credentials is greater than 0
-        // $credentialsCount = count($vpJson['verifiableCredential']);
-        // $this->assertGreaterThan(0, $credentialsCount, 'No VCs were returned in the response.');
+        $vp = $resultJson['vpToken'];
+        $vpJson = json_decode($vp, true);
 
-        // // NOTE: for debugging, no need printing email
-        // $email = $vpJson['verifiableCredential'][0]['credentialSubject']['email'];
-        // echo $email;
+        // Assert that the count of credentials is greater than 0
+        $credentialsCount = count($vpJson['verifiableCredential']);
+        $this->assertGreaterThan(0, $credentialsCount, 'No VCs were returned in the response.');
     }
 }