This repository has been archived by the owner on Aug 29, 2024. It is now read-only.
feat: sol integration #227
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-iskryzhytskyi
requested review from
Volland,
DenisPopov15 and
oleksiipiliugin
Volland
reviewed
Aug 1, 2022
| @@ -10,7 +10,7 @@ | |||
| "tsc": "tsc -p tsconfig-build.json", | |||
| "lint": "eslint src test", | |||
| "test": "npm run test:unit && npm run test:integration", | |||
| "test:unit": "cross-env NODE_ENV=test mocha -r ts-node/register test/unit/index.test.ts -p ./tsconfig.json --timeout 55000", | |||
| "test:unit": "cross-env NODE_ENV=test mocha -r ts-node/register test/unit/index.test.ts -p ./tsconfig.json --timeout 55000 --parallel false", | |||
There was a problem hiding this comment.
@anton-iskryzhytskyi should we return parallel run for tests ?
There was a problem hiding this comment.
is -p stands for parallel? it is better do delete -p here I suppose
Volland
reviewed
Aug 1, 2022
| @@ -49,11 +49,14 @@ | |||
| "@affinidi/tools-common": "^1.0.4", | |||
| "@affinidi/url-resolver": "^1.1.3", | |||
| "@affinidi/vc-common": "^1.4.3", | |||
| "@digitalbazaar/ed25519-signature-2018": "^2.1.0", | |||
There was a problem hiding this comment.
@anton-iskryzhytskyi we need to validate this libs with a React native
Volland
reviewed
Aug 1, 2022
| @@ -21,8 +23,10 @@ const PASSWORD_LENGTH = 32 | |||
| const jolocomIdentityKey = "m/73'/0'/0'/0" // eslint-disable-line | |||
| const etheriumIdentityKey = "m/44'/60'/0'/0/0" // eslint-disable-line | |||
| const elemIdentityPrimaryKey = "m/44'/60'/0'/1/0" // eslint-disable-line | |||
| // why this path: https://docs.solana.com/wallet-guide/paper-wallet#hierarchical-derivation | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature is being investigated