-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#157 Admin Registration Flow Bugfix #158
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… object getting from db, filtering with isWaiting method.
moaydogdu
requested review from
agitrubard,
skayikci and
Rapter1990
as code owners
August 28, 2023 18:12
moaydogdu
added
bug
Something isn't working
highest priority
This issue first priority
in review
This issue in review
labels
Aug 28, 2023
…with ".withValidFields()" method.
Rapter1990
reviewed
Aug 28, 2023
src/test/java/com/ays/admin_user/service/impl/AdminUserRegisterServiceImplTest.java
Show resolved
Hide resolved
src/test/java/com/ays/admin_user/service/impl/AdminUserRegisterServiceImplTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/ays/admin_user/service/impl/AdminUserRegisterServiceImplTest.java
Show resolved
Hide resolved
src/test/java/com/ays/admin_user/service/impl/AdminUserRegisterServiceImplTest.java
Show resolved
Hide resolved
src/test/java/com/ays/admin_user/service/impl/AdminUserRegisterServiceImplTest.java
Show resolved
Hide resolved
src/test/java/com/ays/admin_user/service/impl/AdminUserRegisterServiceImplTest.java
Show resolved
Hide resolved
Rapter1990
requested review from
emreylmaz,
enig,
AhmetAksunger,
anilhazar and
artfulCoder98
September 2, 2023 20:44
Rapter1990
approved these changes
Sep 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
AhmetAksunger
approved these changes
Sep 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
agitrubard
approved these changes
Sep 3, 2023
agitrubard
removed
bug
Something isn't working
highest priority
This issue first priority
in review
This issue in review
labels
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST TEMPLATE
Description
The problem of using the Verification ID in the Admin Registration Flow more than once.
Related Issue
#157 "Admin Kayıt Akışındaki Verification ID'nin Birden Fazla Kez Kullanılması"
Proposed Changes
The problem was solved by throwing an "AysAdminUserRegisterVerificationCodeNotValidException" error when the "verification id" value used during the creation of a new admin is not "AdminUserRegisterVerificationStatus.WAITING". At the end of the related flow, the status of the "AdminUserRegisterVerificationEntity" object associated with the "verification id" is already changed to "AdminUserRegisterVerificationStatus.COMPLETED".
In this way, when the request is sent again with the same verification id value, the "AysAdminUserRegisterVerificationCodeNotValidException" error is thrown because it is "AdminUserRegisterVerificationStatus.COMPLETED" and reuse is prevented.
Checklist
Please check the following before submitting your pull request:
board or milestone. However, if there is no issue, the pull request should be associated with the appropriate project
board (BE Board, In Review column) and milestone to track the progress.
Reviewers
@agitrubard @skayikci @Rapter1990