Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#157 Admin Registration Flow Bugfix #158

Merged
merged 7 commits into from
Sep 3, 2023

Conversation

moaydogdu
Copy link
Contributor

@moaydogdu moaydogdu commented Aug 28, 2023

PULL REQUEST TEMPLATE

Description

The problem of using the Verification ID in the Admin Registration Flow more than once.

Related Issue

#157 "Admin Kayıt Akışındaki Verification ID'nin Birden Fazla Kez Kullanılması"

Proposed Changes

The problem was solved by throwing an "AysAdminUserRegisterVerificationCodeNotValidException" error when the "verification id" value used during the creation of a new admin is not "AdminUserRegisterVerificationStatus.WAITING". At the end of the related flow, the status of the "AdminUserRegisterVerificationEntity" object associated with the "verification id" is already changed to "AdminUserRegisterVerificationStatus.COMPLETED".

In this way, when the request is sent again with the same verification id value, the "AysAdminUserRegisterVerificationCodeNotValidException" error is thrown because it is "AdminUserRegisterVerificationStatus.COMPLETED" and reuse is prevented.

Checklist

Please check the following before submitting your pull request:

  • I have tested my changes locally and they are working as expected.
  • The code is formatted according to the project's coding guidelines and style.
  • Necessary documentation has been added or existing documentation has been updated.
  • Relevant unit tests have been written and included.
  • Relevant integration tests have been written and included.
  • The code has been reviewed to ensure its quality.
  • The code does not contain any issues flagged by SonarLint.
  • Default reviewers have been assigned to this pull request.
  • Assignees have been added if necessary.
  • Labels have been applied if necessary.
  • If an issue is opened and this pull request is related to that issue, it should not be associated with any project
    board or milestone. However, if there is no issue, the pull request should be associated with the appropriate project
    board (BE Board, In Review column) and milestone to track the progress.

Reviewers

@agitrubard @skayikci @Rapter1990

@moaydogdu moaydogdu self-assigned this Aug 28, 2023
@moaydogdu moaydogdu added bug Something isn't working highest priority This issue first priority in review This issue in review labels Aug 28, 2023
Copy link
Contributor

@Rapter1990 Rapter1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@AhmetAksunger AhmetAksunger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agitrubard agitrubard merged commit 9c5a652 into main Sep 3, 2023
1 check passed
@agitrubard agitrubard deleted the bugfix/157/admin-registration-flow branch September 3, 2023 13:27
@agitrubard agitrubard removed bug Something isn't working highest priority This issue first priority in review This issue in review labels Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin Kayıt Akışındaki Verification ID'nin Birden Fazla Kez Kullanılması
4 participants