-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#146 | Implement the process of Assignment for Save Operation #147
Conversation
…mentSavedResponseMapper
…y, AssignmentServiceImpl, AssignmentStatus, AssignmentUpdateRequest
…entController and AssignmentControllerTest
src/test/java/com/ays/assignment/service/impl/AssignmentSaveServiceImplTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/ays/assignment/controller/AssignmentControllerTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uygulama katmanını kontrol ettim ve bununla ilgili yorumlarımı yaptım, test tarafını geliştirmeler düzeltildikten sonra review ediyor olacam, ek olarak sistem testlerini de yazmamız gerekiyor
src/main/java/com/ays/assignment/model/dto/request/AssignmentSaveRequest.java
Show resolved
Hide resolved
src/main/java/com/ays/assignment/model/dto/request/AssignmentSaveRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/ays/assignment/controller/AssignmentController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/ays/assignment/model/dto/request/AssignmentUpdateRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/ays/assignment/model/dto/response/AssignmentSavedResponse.java
Outdated
Show resolved
Hide resolved
src/main/java/com/ays/assignment/model/enums/AssignmentStatus.java
Outdated
Show resolved
Hide resolved
src/main/java/com/ays/assignment/model/mapper/AssignmentToAssignmentSavedResponseMapper.java
Outdated
Show resolved
Hide resolved
src/main/java/com/ays/assignment/service/impl/AssignmentSaveServiceImpl.java
Show resolved
Hide resolved
src/main/java/com/ays/assignment/service/impl/AssignmentSaveServiceImpl.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks cool to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eline sağlık, approved ✅
…tMapper, AssignmentSaveRequestToAssignmentMapper, AssignmentToAssignmentEntityMapper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
PULL REQUEST TEMPLATE
Description
The aim of this pull request to Implement the process of Assignment for Save Operation
Related Issue
#146
Proposed Changes
Please provide a brief and descriptive title for your pull request, summarizing the changes or features introduced. It
should be in English and clearly indicate the purpose of the pull request. Optionally, you can provide a more detailed
description of what you have done.
Naming Conventions of Branchs
header in README.md FileAdditional Information
If there's any additional information or context that the reviewers should know, please provide it here.
AysLocationUtil
to handle with creating aPoint
with respect to latitude and longitude information from requestAssignment
OperationJUnit Test
andIntegration Test
for saving anAssignment
processAssignmentEntityBuilder
builder to add Point for its builder pattern.Java Doc
for all method related with the process of savingAssignment
Checklist
Please check the following before submitting your pull request:
board or milestone. However, if there is no issue, the pull request should be associated with the appropriate project
board (BE Board, In Review column) and milestone to track the progress.
Reviewers
The default project maintainers and team members will be automatically assigned as reviewers for this pull request.