Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#146 | Implement the process of Assignment for Save Operation #147

Merged
merged 54 commits into from
Aug 22, 2023

Conversation

Rapter1990
Copy link
Contributor

@Rapter1990 Rapter1990 commented Aug 15, 2023

PULL REQUEST TEMPLATE

Description

The aim of this pull request to Implement the process of Assignment for Save Operation

Related Issue

#146

Proposed Changes

Please provide a brief and descriptive title for your pull request, summarizing the changes or features introduced. It
should be in English and clearly indicate the purpose of the pull request. Optionally, you can provide a more detailed
description of what you have done.

  • Branches should follow the below Naming Conventions of Branchs header in README.md File

Additional Information

If there's any additional information or context that the reviewers should know, please provide it here.

  • Create AysLocationUtil to handle with creating a Point with respect to latitude and longitude information from request
  • Save Assignment Operation
  • Define JUnit Test and Integration Test for saving an Assignment process
  • Define AssignmentEntityBuilder builder to add Point for its builder pattern.
  • Add Java Doc for all method related with the process of saving Assignment

Checklist

Please check the following before submitting your pull request:

  • I have tested my changes locally and they are working as expected.
  • The code is formatted according to the project's coding guidelines and style.
  • Necessary documentation has been added or existing documentation has been updated.
  • Relevant unit tests have been written and included.
  • Relevant integration tests have been written and included.
  • The code has been reviewed to ensure its quality.
  • The code does not contain any issues flagged by SonarLint.
  • Default reviewers have been assigned to this pull request.
  • Assignees have been added if necessary.
  • Labels have been applied if necessary.
  • If an issue is opened and this pull request is related to that issue, it should not be associated with any project
    board or milestone. However, if there is no issue, the pull request should be associated with the appropriate project
    board (BE Board, In Review column) and milestone to track the progress.

Reviewers

The default project maintainers and team members will be automatically assigned as reviewers for this pull request.

@Rapter1990 Rapter1990 changed the title Implement the process of Assignment for CRUD operations Implement the process of Assignment for Save Operation Aug 15, 2023
@Rapter1990 Rapter1990 self-assigned this Aug 15, 2023
@Rapter1990 Rapter1990 linked an issue Aug 15, 2023 that may be closed by this pull request
Copy link
Collaborator

@agitrubard agitrubard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uygulama katmanını kontrol ettim ve bununla ilgili yorumlarımı yaptım, test tarafını geliştirmeler düzeltildikten sonra review ediyor olacam, ek olarak sistem testlerini de yazmamız gerekiyor

@Rapter1990 Rapter1990 changed the title Implement the process of Assignment for Save Operation #146 | Implement the process of Assignment for Save Operation Aug 19, 2023
moaydogdu
moaydogdu previously approved these changes Aug 20, 2023
Copy link
Contributor

@moaydogdu moaydogdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool to me!

agitrubard
agitrubard previously approved these changes Aug 20, 2023
Copy link
Collaborator

@agitrubard agitrubard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eline sağlık, approved ✅

moaydogdu
moaydogdu previously approved these changes Aug 20, 2023
@Rapter1990 Rapter1990 dismissed stale reviews from moaydogdu and agitrubard via 6f8ab8d August 20, 2023 21:56
moaydogdu
moaydogdu previously approved these changes Aug 21, 2023
…tMapper, AssignmentSaveRequestToAssignmentMapper, AssignmentToAssignmentEntityMapper
Copy link
Collaborator

@skayikci skayikci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@agitrubard agitrubard merged commit 02035a6 into main Aug 22, 2023
2 checks passed
@agitrubard agitrubard deleted the feature/146/assignment-process branch August 22, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Atama Oluşturma Servisinin Hazırlanması
4 participants