This repository has been archived by the owner on Oct 13, 2022. It is now read-only.
#82 force-revoke 時に exh_id を null にするようにした #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
どうやら exh の Guest 人数取得の時に、revoked_at がセットされていれば滞在人数から除外するようになってるので別にこの変更は必須ではないかもしれないです |
|
めっちゃ色々勘違いしてた 元から人数カウントの時に revokeされていないもの を条件にしているので、この修正いらないです |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #82
本当は revoke 時にする〜、みたいに書いた方がいいんかな、、