Skip to content

Commit

Permalink
switch to xfail for slide count test
Browse files Browse the repository at this point in the history
  • Loading branch information
afeld committed Oct 20, 2024
1 parent db6baa4 commit 4e034a4
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions extras/test_notebooks.py
Original file line number Diff line number Diff line change
Expand Up @@ -176,12 +176,10 @@ def test_num_slides(file):

notebook = read_notebook(file)

# known issue that these lectures have too many slides
if file in ["lecture_1.ipynb", "lecture_2.ipynb"]:
return
# the various pieces of the lecture can be scaled appropriately
pytest.xfail("Known issue that these lectures have too many slides")
if file == "lecture_6.ipynb":
return
pytest.xfail("The various pieces of the lecture can be scaled appropriately")

columbia = [cell for cell in notebook.cells if "nyu-only" not in get_tags(cell)]
num_columbia = num_slides(columbia)
Expand Down

0 comments on commit 4e034a4

Please sign in to comment.