Skip to content

Commit

Permalink
fix(GitLab): Named release
Browse files Browse the repository at this point in the history
Propagate tag name into name of release
Fixes #308
  • Loading branch information
dido-dids authored and kodiakhq[bot] committed Mar 10, 2022
1 parent 84cdbe4 commit 3b5cefa
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
4 changes: 2 additions & 2 deletions internal/gitlab/publish_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ func TestPublishExistingRelease(t *testing.T) {

assert.NoError(t, err)

expectedBody := fmt.Sprintf("{\"name\":\"\",\"tag_name\":\"%v\",\"description\":\"%v\"}", tagName, newReleaseNotes)
expectedBody := fmt.Sprintf("{\"tag_name\":\"%v\",\"description\":\"%v\"}", tagName, newReleaseNotes)

assert.Equal(t, expectedBody, string(body))

Expand Down Expand Up @@ -64,7 +64,7 @@ func TestPublishNewRelease(t *testing.T) {

assert.NoError(t, err)

expectedBody := fmt.Sprintf("{\"name\":\"\",\"tag_name\":\"%v\",\"description\":\"%v\"}", tagName, newReleaseNotes)
expectedBody := fmt.Sprintf("{\"tag_name\":\"%v\",\"description\":\"%v\"}", tagName, newReleaseNotes)

assert.Equal(t, expectedBody, string(body))

Expand Down
1 change: 0 additions & 1 deletion internal/gitlab/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ type Gitlab struct {
}

type gitlabRelease struct {
Name string `json:"name"`
TagName string `json:"tag_name"`
Message string `json:"description"`
}
Expand Down

0 comments on commit 3b5cefa

Please sign in to comment.