Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPI functionality for the Photon struct #51

Merged
merged 7 commits into from
Feb 1, 2024
Merged

MPI functionality for the Photon struct #51

merged 7 commits into from
Feb 1, 2024

Conversation

EdHone
Copy link
Collaborator

@EdHone EdHone commented Jan 23, 2024

This PR enables the functionality to pass an instance of the Photon struct between processes using MPI. This functionality can be tested by enabling the mpi feature, as well as by running a test case with mpi:

cargo mpirun --features mpi --bin mpi_tests -n 2

@EdHone EdHone mentioned this pull request Jan 23, 2024
Closed
sammorrell
sammorrell approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@sammorrell sammorrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Implements the Equivalence trait for Photon struct so that we can pass across MPI boundaries. Tested locally with OpenMPI 5.0.1 and works well.

@sammorrell sammorrell changed the base branch from main to develop February 1, 2024 17:27
@sammorrell sammorrell merged commit fbbcc1c into develop Feb 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sammorrell sammorrell sammorrell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EdHone @sammorrell