Re-implementing the mesh input to enable multiple file types #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sammorrell
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
Looks good. I agree with the abstraction of the File implementation for Mesh over different file types. Makes sense to support the different input file types.
I have downloaded and run the integration in aetherus-tests with this compiled and it passes. So, I will merge this in next week when I have merged in the new unit tests and published a release.
As you said, it would be good to have a UGRID reading test case in the integration tests as well, so let's look at adding a basic test case in to make sure that we can replicate the same behaviour as with the OBJ input, just to be certain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The netcdf-ugrid file type offers a benefit in terms of file size and parallel I/O capability via parallel netcdf, but should not replace the existing .obj mesh files which are useful for their flexibility, particularly where mesh size is not an issue (for non-geographical assets for example).
This PR enables mesh objects to be read from mutiple file sources. This is achieved by moving the mesh file implementation into the mesh module, and altering the interface provided by the wavefront fs module. This interface is copied by the new ugrid fs module and both are used by the new mesh-file implementation.
Unit tests have been added.