Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Om139 #84

Merged
merged 10 commits into from
Nov 8, 2023
Merged

Om139 #84

merged 10 commits into from
Nov 8, 2023

Conversation

mphanias
Copy link
Contributor

7.0 changes - initial changes to support multi-cluster view

modified queries according to the 7.0 stat and metrics
added all-cluster master-object and unique-usage-bytes view which are all connected to a prometheus instance
added historical view for all-cluster rows,
modified alert-panel to display as a pie chart
fixed url link bug
corrected wrong checking of unique data view.
this unique-data is taken as part of jira-129
1. modified diagram constructing query to use only cluster-name, dc and ns - as we dont require to show connector types - (simplified overall query)
2. used max in xdr_lag instead of sum
3. added separate query to show server without any xdr-connections
4. updated panel title to show total / max
fixed query to use only cluster-name, dc and ns
added a join with objects to add diagrams even if there is no XDR configured
added extra query and variable to show different images for server and connectors
Copy link
Collaborator

@hev hev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still scenarios where a warning results in a red hex. We should filter the namespace and node panels to critical instead of the variable and remove the variable.

Cursor_and_Multi_Cluster_View_-7p_-_Dashboards_-_Grafana

modified alerts query to consider only "critical" severity
fixed alert url link
@mphanias
Copy link
Contributor Author

mphanias commented Nov 1, 2023

modified alert query to consider only "critical" severity while showing color in Node (Hex) and Namespace panels

@mphanias mphanias requested a review from hev November 1, 2023 15:25
@mphanias
Copy link
Contributor Author

mphanias commented Nov 1, 2023

removed alert- severity filter variable also, as it is no more required

modified alert severity to use critical, warn or error during display
Copy link
Collaborator

@hev hev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think version 7941947 was better. If we can only choose two colors it should be red (with hardcoded critical filter) or green for no critical.

@mphanias
Copy link
Contributor Author

mphanias commented Nov 7, 2023

keeping only RED colour, however using only "critical", mean some key alerts which are marked as warn / error (example XDRTimelag a warn alert) will not show any indication, may leave user with assumption of all-is-good.
I am thinking of these options, 1. use critical/warn or 2. look at all warn alerts and adjust the severity as critical or appropriate

@mphanias mphanias requested a review from hev November 7, 2023 06:12
modified alert-severity level to "critical" and "warn" in all 3 panels ( world-map, nodes and namespace)
removed un-used queries as fixed alert-severity
Copy link
Collaborator

@hev hev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK with this version.

@sunilvirus sunilvirus merged commit 1d4faef into dev Nov 8, 2023
1 check passed
@sunilvirus sunilvirus deleted the OM139 branch November 8, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants