Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLIENT-2239] CI/CD: Use massif to get Python client memory usage over time while running integration tests #664

Merged
merged 5 commits into from
Sep 4, 2024

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Sep 3, 2024

Removed pytest-memray test, since it's not needed for CI/CD regression testing; only for debugging

Note: Did not test the last commit: Show massif output even if tests failed

Testing:

Metrics code has a memory leak. Massif does show increased memory usage (double that of dev): https://github.com/aerospike/aerospike-client-python/actions/runs/10706083490/job/29682962437#step:12:19
Run on dev: https://github.com/aerospike/aerospike-client-python/actions/runs/10690461665/job/29634968764#step:13:20
Can still run memcheck. No regression in ci/cd code: https://github.com/aerospike/aerospike-client-python/actions/runs/10690463167/job/29634968672

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.33%. Comparing base (1ffc37d) to head (be634be).
Report is 4 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #664   +/-   ##
=======================================
  Coverage   81.33%   81.33%           
=======================================
  Files         100      100           
  Lines       15346    15346           
=======================================
  Hits        12482    12482           
  Misses       2864     2864           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliannguyen4 juliannguyen4 marked this pull request as ready for review September 4, 2024 17:32
Copy link
Contributor

@justinlee-aerospike justinlee-aerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good

@juliannguyen4 juliannguyen4 merged commit e073721 into dev Sep 4, 2024
44 of 46 checks passed
@juliannguyen4 juliannguyen4 deleted the CLIENT-2239-cicd-massif branch September 4, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants