Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVOPS-198] Run cleanup script on Mac M1 runners when job starts #657

Merged
merged 27 commits into from
Aug 20, 2024

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Aug 2, 2024

Extra changes:
Build the Mac arm64 wheels using the Github runners instead of the self-hosted Mac M1 runners

Workflow testing:

The latest run (custom server tag) should successfully cleanup the Mac M1 runner:

  • Make sure crudini is always installed
  • Make sure aerospike server base image is always pulled
  • make sure requirements.txt always installs packages

Minor bug I fixed after running these tests but I didn't bother testing it: b9287e3

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.33%. Comparing base (b899e82) to head (c09ceec).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #657   +/-   ##
=======================================
  Coverage   81.33%   81.33%           
=======================================
  Files         100      100           
  Lines       15341    15341           
=======================================
  Hits        12477    12477           
  Misses       2864     2864           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliannguyen4 juliannguyen4 marked this pull request as ready for review August 19, 2024 19:02
Copy link
Contributor

@justinlee-aerospike justinlee-aerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look fine

@juliannguyen4 juliannguyen4 merged commit 856d43d into dev Aug 20, 2024
62 of 63 checks passed
@juliannguyen4 juliannguyen4 deleted the DEVOPS-198-mac-m1-cleanup branch August 20, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants