[CLIENT-3027] CI/CD: Use Dockerfile to build Docker image for Aerospike enterprise server with security enabled #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #645 +/- ##
=======================================
Coverage 81.33% 81.33%
=======================================
Files 100 100
Lines 15341 15341
=======================================
Hits 12477 12477
Misses 2864 2864 ☔ View full report in Codecov by Sentry. |
juliannguyen4
changed the title
justinlee-aerospike
requested changes
Jul 16, 2024
| if [[ $is_security_enabled == true ]]; then | ||
| # We need to pass credentials to asinfo if server requires it | ||
| # TODO: passing in hardcoded credentials since I can't figure out how to use --instance with global astools.conf | ||
| user_credentials="--user=admin --password=admin" |
There was a problem hiding this comment.
store the user and password credentials in a github secret
There was a problem hiding this comment.
This is the default credentials for the Aerospike EE server with security enabled. I don't think using secrets here is necessary unless we change those credentials
justinlee-aerospike
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extra changes:
Workflow regression testing
Build wheels (including macOS x86 testing):
With latest tag by default: https://github.com/aerospike/aerospike-client-python/actions/runs/9959790445/job/27517447730
With custom server tag: https://github.com/aerospike/aerospike-client-python/actions/runs/9960467374
Stage tests (all tests pass except for noise): https://github.com/aerospike/aerospike-client-python/actions/runs/9960475436
Valgrind: https://github.com/aerospike/aerospike-client-python/actions/runs/9960475827
Dev workflow part 1: https://github.com/aerospike/aerospike-client-python/actions/runs/9960479630