Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLIENT-3017] CI/CD: Wait for Aerospike server Docker container to be ready using asinfo instead of a time delay #642

Merged
merged 58 commits into from
Jul 8, 2024

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Jun 28, 2024

Extra changes

  • Fix dev-workflow-p1 not skipping server release tests

PR tests pass (except for failure unrelated to this change). see status checks
dev-workflow-p1 passes: https://github.com/aerospike/aerospike-client-python/actions/runs/9844997400/job/27180101352
Stage tests pass: https://github.com/aerospike/aerospike-client-python/actions/runs/9845019760
Valgrind passes: https://github.com/aerospike/aerospike-client-python/actions/runs/9845023815

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.33%. Comparing base (83aefb8) to head (931968c).
Report is 5 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #642   +/-   ##
=======================================
  Coverage   81.33%   81.33%           
=======================================
  Files         100      100           
  Lines       15341    15341           
=======================================
  Hits        12477    12477           
  Misses       2864     2864           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliannguyen4 juliannguyen4 marked this pull request as ready for review July 3, 2024 22:02
@juliannguyen4 juliannguyen4 added the new-server-features Test against the latest server release candidate label Jul 8, 2024
@juliannguyen4 juliannguyen4 requested review from justinlee-aerospike and removed request for justinlee-aerospike July 8, 2024 15:47
Copy link
Contributor

@justinlee-aerospike justinlee-aerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are fine

@juliannguyen4 juliannguyen4 merged commit 07cd6bb into dev Jul 8, 2024
172 of 178 checks passed
@juliannguyen4 juliannguyen4 deleted the CLIENT-3017-cicd-healthcheck branch July 8, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-server-features Test against the latest server release candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants