Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLIENT-3000] Fix scans not working for a mixed cluster of 5.7 and 6.4 nodes #632

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Jun 10, 2024

Some noisy test results but they don't appear related to any changes in the C client: https://github.com/aerospike/aerospike-client-python/actions/runs/9568271397/job/26378076313

Changes in C client submodule: aerospike/aerospike-client-c@ed48fdf...54e2507

Assuming that the C client changes have already been tested using valgrind, so I won't run the valgrind workflow here

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.33%. Comparing base (0de5226) to head (e35606e).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #632   +/-   ##
=======================================
  Coverage   81.33%   81.33%           
=======================================
  Files         100      100           
  Lines       15341    15341           
=======================================
  Hits        12477    12477           
  Misses       2864     2864           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliannguyen4 juliannguyen4 marked this pull request as ready for review June 18, 2024 15:54
Copy link
Contributor

@justinlee-aerospike justinlee-aerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good

@juliannguyen4 juliannguyen4 merged commit c82c5c9 into dev Jun 21, 2024
54 of 56 checks passed
@juliannguyen4 juliannguyen4 deleted the CLIENT-3000-scan-mixed-cluster branch June 21, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants