Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLIENT-1837] CI/CD: Fix using the wrong repository URL when uploading JFrog builds to pypi.org #626

Merged
merged 1 commit into from
May 31, 2024

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented May 31, 2024

This fix allowed me to upload 15.0.1rc2 from JFrog to PyPI: https://github.com/aerospike/aerospike-client-python/actions/runs/9323099458

The test.pypi.org link worked before, but not the pypi.org link

@juliannguyen4 juliannguyen4 marked this pull request as ready for review May 31, 2024 19:12
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.33%. Comparing base (ac4f4c4) to head (000b94d).
Report is 7 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #626      +/-   ##
==========================================
- Coverage   81.35%   81.33%   -0.03%     
==========================================
  Files         100      100              
  Lines       15358    15341      -17     
==========================================
- Hits        12494    12477      -17     
  Misses       2864     2864              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@justinlee-aerospike justinlee-aerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look fine

@juliannguyen4 juliannguyen4 merged commit 7b082c2 into dev May 31, 2024
83 of 85 checks passed
@juliannguyen4 juliannguyen4 deleted the CLIENT-1837-cicd-fix-pypi-url branch May 31, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants