Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLIENT-2970] CI/CD: Use manylinux wheel instead of a local build for valgrind workflow #624

Merged
merged 2 commits into from
May 31, 2024

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented May 28, 2024

TODO: need to optimize valgrind workflow by only building manylinux wheels and ignoring all the other platforms. Currently working on this in another PR for refactoring the GHA code

These changes seem to work as tested in CLIENT-681-Refactor branch

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.33%. Comparing base (ac4f4c4) to head (3bca126).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #624      +/-   ##
==========================================
- Coverage   81.35%   81.33%   -0.02%     
==========================================
  Files         100      100              
  Lines       15358    15343      -15     
==========================================
- Hits        12494    12479      -15     
  Misses       2864     2864              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliannguyen4 juliannguyen4 marked this pull request as ready for review May 29, 2024 22:35
Copy link
Contributor

@justinlee-aerospike justinlee-aerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good

@juliannguyen4 juliannguyen4 merged commit 480688a into dev May 31, 2024
137 of 138 checks passed
@juliannguyen4 juliannguyen4 deleted the CLIENT-2970-cicd-valgrind-manylinux branch May 31, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants