Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLIENT-1938] Remove aerospike.__version__ to single source the client's version #623

Merged
merged 3 commits into from
May 31, 2024

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented May 28, 2024

Doc changes
https://aerospike-python-client--623.org.readthedocs.build/en/623/aerospike.html#miscellaneous

Regression test

Workflow to bump and update version still works: https://github.com/aerospike/aerospike-client-python/actions/runs/9287695613

TODO

  • delete tag generated by test workflow

@juliannguyen4 juliannguyen4 changed the title [CLIENT-1938] Set version in pyproject.toml and remove VERSION [CLIENT-1938] Remove aerospike.__version__ to single source the client's version May 28, 2024
@juliannguyen4 juliannguyen4 marked this pull request as ready for review May 29, 2024 18:50
Copy link
Contributor

@justinlee-aerospike justinlee-aerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good

@juliannguyen4 juliannguyen4 merged commit b1f95ca into dev May 31, 2024
71 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants