Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLIENT-1837] CI/CD: Refactor build wheels workflow #622

Merged
merged 153 commits into from
Aug 30, 2024

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented May 22, 2024

Main changes:

  • Change build-wheels.yml to only build for one platform
  • Create another workflow to build all wheels and source distribution (main purpose is to build for CI/CD stages)

Extra changes:

  • Create composite action to setup Docker on macOS x86
  • Fixes a bug where build-wheels.yml tests against a server RC by default instead of server release for workflow_call events

build-wheels.yml:

  • Default
  • Build a single wheel
  • Build and test (The rest of the tests only use a single wheel to save resources)
  • Server RC
  • Server tag
  • Unoptimized
  • DSYM

Workflows that depend on build-wheels

  • Valgrind:
  • Build sdist:
  • Build and run stage tests:

Build artifacts:

  • Run tests

Make sure macos x86 tests aren't run:

  • Dev workflow p1
  • Dev workflow p2
  • Dev to stage
  • Stage to master

Reverted github variables to their real values

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.33%. Comparing base (856d43d) to head (1725579).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #622   +/-   ##
=======================================
  Coverage   81.33%   81.33%           
=======================================
  Files         100      100           
  Lines       15341    15341           
=======================================
  Hits        12477    12477           
  Misses       2864     2864           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliannguyen4 juliannguyen4 marked this pull request as ready for review August 27, 2024 18:34
Copy link
Contributor

@justinlee-aerospike justinlee-aerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good

@juliannguyen4 juliannguyen4 merged commit 6ab14fc into dev Aug 30, 2024
67 of 71 checks passed
@juliannguyen4 juliannguyen4 deleted the CLIENT-1837-cicd-refactor branch August 30, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants