Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLIENT-1837] CI/CD: Use JFrog builds instead of rebuilding wheels when running dev-to-stage.yml #610

Merged
merged 62 commits into from
Jun 19, 2024

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Apr 29, 2024

TODO: delete tags from testing
Revert variables to their original values

Extra changes:

Fixes dev-to-stage.yml failing to upload artifacts with promoted version (dev to RC) if the stage tests were run and not skipped

Testing

Build and run stage tests:
Default settings: https://github.com/aerospike/aerospike-client-python/actions/runs/9586744026
Use server RC true: https://github.com/aerospike/aerospike-client-python/actions/runs/9587251791
Server tag set: https://github.com/aerospike/aerospike-client-python/actions/runs/9587268809
macOS x86 testing enabled (noisy results): https://github.com/aerospike/aerospike-client-python/actions/runs/9587270517/job/26437328365

dev-to-stage:
Stage tests download JFrog artifacts and they pass: https://github.com/aerospike/aerospike-client-python/actions/runs/9586694470
Stage tests skip and the rest of the workflow now passes instead of fails: https://github.com/aerospike/aerospike-client-python/actions/runs/9588686667/job/26441513199

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.33%. Comparing base (0de5226) to head (1f867b4).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #610   +/-   ##
=======================================
  Coverage   81.33%   81.33%           
=======================================
  Files         100      100           
  Lines       15341    15341           
=======================================
  Hits        12477    12477           
  Misses       2864     2864           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliannguyen4 juliannguyen4 marked this pull request as ready for review June 19, 2024 22:29
Copy link
Contributor

@justinlee-aerospike justinlee-aerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good

@juliannguyen4 juliannguyen4 merged commit 039bac9 into dev Jun 19, 2024
24 checks passed
@juliannguyen4 juliannguyen4 deleted the CLIENT-1837-use-jfrog-builds branch June 19, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants