[CLIENT-1837] CI/CD: Label version with git commit when building on a non-tagged commit #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…files and line numbers on macOS when debugging
juliannguyen4
changed the title
…ommit-in-version
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #605 +/- ##
=======================================
Coverage 81.35% 81.35%
=======================================
Files 100 100
Lines 15356 15356
=======================================
Hits 12493 12493
Misses 2863 2863 ☔ View full report in Codecov by Sentry. |
…ommit-in-version
justinlee-aerospike
approved these changes
May 8, 2024
DomPeliniAerospike
added a commit
that referenced
this pull request
May 22, 2024
* [CLIENT-1837] CI/CD: Label version with git commit when building on a non-tagged commit (#605) * Also label version when building unoptimized, with macOS debug support, or with uncommitted changes to the repo (i.e add a "dirty" label) * Rename config.conf to config.conf.template and add config.conf to .gitignore, so creating and modifying config.conf won't cause the repo to be in a dirty state * Auto-bump version to 15.0.1rc3.dev1 [skip ci] * [DEVOPS-234] CI/CD: Build manylinux wheels and upload them to JFrog on every push to an arbitrary branch (#606) * CI/CD: Add option to build and upload unoptimized wheels to JFrog for QE * Auto-bump version to 15.0.1rc3.dev2 [skip ci] --------- Co-authored-by: juliannguyen4 <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
aerospike.__version__is not updated to include any local version identifiers (i.e+<string>) by versioningit, so it is outdated. This should not matter for release versions since they should not include local version identifiersLocal feature testing. Wheel names for:
aerospike-15.0.1rc2.dev8+38.g853cc8eb-cp311-cp311-macosx_14_0_arm64.whlaerospike-16.0.0-cp311-cp311-macosx_14_0_arm64.whlaerospike-16.0.0+0.g853cc8eb.dirty-cp311-cp311-macosx_14_0_arm64.whlaerospike-15.0.1rc2.dev8+38.g853cc8eb.dirty-cp311-cp311-macosx_14_0_arm64.whlFeature testing on Github Actions (Build wheels):
Wheel names produced by these jobs are all correct:
Regression testing
Do these workflows still create a valid config.conf and connect to the server successfully for testing?
TODO
Let QE know about changes to config.conf