Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

refactor: migrate to use upstream GraphQL #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

namit-chandwani
Copy link
Member

@namit-chandwani namit-chandwani commented Mar 29, 2021

An attempt to fix the issue: aerogear/graphql-link#41.
Based on discussions in PR: aerogear/graphql-link#57.

Checklist of Imports

Following is a list of imports that graphql-link uses from this fork of graphql.

I have planned to work on one package at a time and update this checklist as soon as that package is successfully converted to make use of the upstream GraphQL repo.

  • "github.com/chirino/graphql"
  • "github.com/chirino/graphql/schema"
  • "github.com/chirino/graphql/qerrors"
  • "github.com/chirino/graphql/graphiql" (Entirely new package, no change needed)
  • "github.com/chirino/graphql/httpgql"
  • "github.com/chirino/graphql/resolvers"
  • "github.com/chirino/graphql/exec"
  • "github.com/chirino/graphql/customtypes" (Not directly used by graphql-link)

Further comments

The commit currently attached to this PR makes the "github.com/chirino/graphql/qerrors" package to import and use the "github.com/graph-gophers/graphql-go/errors" package of upstream repo by making some changes in the relevant files.

Once this commit change gets approved, I'll proceed to work on any of the remaining packages from the checklist above, by adding further commits to this PR itself.

If there is any fault in my approach then please let me know, I would be happy to make the necessary changes according to the requirements.

@wtrocki
Copy link

wtrocki commented Apr 4, 2021

I haven't seen this PR. Looks amazing

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants