Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Migrate to use upstream GraphQL #41

Open
wtrocki opened this issue Feb 13, 2021 · 11 comments
Open

Migrate to use upstream GraphQL #41

wtrocki opened this issue Feb 13, 2021 · 11 comments
Assignees
Labels

Comments

@wtrocki
Copy link
Contributor

wtrocki commented Feb 13, 2021

Currently we are using Chirino fork of the GraphQL.
GraphQL implementation moved forward we should investigate how much work will be needed to migrate

@wtrocki wtrocki added the gsoc label Feb 13, 2021
@wtrocki wtrocki changed the title Migrate to use upstream GraphQL li Migrate to use upstream GraphQL Feb 15, 2021
@ankithans
Copy link
Member

Can I start working on it?
There are some extra files and folders in Chirino's fork. If we switch to upstream then there will be issues ig

@ankithans
Copy link
Member

ankithans commented Mar 2, 2021

The version which we are using has some additional go modules but the upstream version doesn't have it. And those modules are used widely in the project. So what should I do for them now?

I can list the modules that are not in upstream if required.

Chirino version was forked at this point and then he added modules over it https://github.com/graph-gophers/graphql-go/tree/25d6d94fa7a7f2b0ce10fd509e54e85f7a2f866b

our upstream

@wtrocki
Copy link
Contributor Author

wtrocki commented Mar 2, 2021

Ok. I'm aware of this, but what you expect me to do with this info? What is your question?
I would start with fixing CORS or JSON parse issues to get more familiar with the project.

@ankithans
Copy link
Member

So my question is when I replace the imports everywhere from github.com/chirino/graphql to github.com/graph-gophers/graphql-go, there will be errors coming up for the modules which are not there.

So how should I include those modules in our project? Like should I add them as modules in graphql-link ?

@wtrocki
Copy link
Contributor Author

wtrocki commented Mar 2, 2021

This is low level implementation question. I guess you need those from somewhere.

@ankithans
Copy link
Member

ankithans commented Mar 2, 2021

Yeah, they are available in github.com/chirino/graphql. I can include and update the necessary ones in graphql-link. If that sound fine?

@wtrocki
Copy link
Contributor Author

wtrocki commented Mar 2, 2021

Not sure what you mean TBH. Let's create PR with explanation what was done.

@ankithans
Copy link
Member

Okay sure @wtrocki, will create PR soon. After working on the issue, I will also have more clarity.

@wtrocki
Copy link
Contributor Author

wtrocki commented Mar 2, 2021

Trust me - it will not be soon. There is more than week of work on migration IMHO.
Please try some easiest issues first

@ankithans
Copy link
Member

yeah realizing 🥲

Please try some easiest issues first

okay, got it!

@namit-chandwani
Copy link
Member

@wtrocki Can you please assign this issue to me? Will start working on it right away

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants