Merge pull request #56 from aerogear/framework-field

feat: AppMetric struct accepts a Framework field
aerogear-attic · May 10, 2018 · c37fb04 · c37fb04
2 parents f2dd0e9 + 38c524e
commit c37fb04
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/README.md b/README.md
@@ -103,7 +103,8 @@ curl -i -X POST \
     "app": {
       "appId": "com.example.someApp",
       "sdkVersion": "2.4.6",
-      "appVersion": "256"
+      "appVersion": "256",
+      "framework": "native"
     },
     "device": {
       "platform": "android",

diff --git a/pkg/mobile/metrics_test.go b/pkg/mobile/metrics_test.go
@@ -37,6 +37,7 @@ func TestCreateCallsDAOWithCorrectArgs(t *testing.T) {
 				ID:         "12345678",
 				SDKVersion: "1.0.0",
 				AppVersion: "1",
+				Framework:  "native",
 			},
 			Device: &DeviceMetric{
 				Platform:        "Android",
@@ -77,6 +78,7 @@ func TestCreateReturnsErrorFromDAO(t *testing.T) {
 				ID:         "12345678",
 				SDKVersion: "1.0.0",
 				AppVersion: "1",
+				Framework:  "native",
 			},
 			Device: &DeviceMetric{
 				Platform:        "Android",
@@ -115,6 +117,7 @@ func TestCreateCallsDaoWithCorrectTimestamp(t *testing.T) {
 				ID:         "12345678",
 				SDKVersion: "1.0.0",
 				AppVersion: "1",
+				Framework:  "native",
 			},
 			Device: &DeviceMetric{
 				Platform:        "Android",

diff --git a/pkg/mobile/types.go b/pkg/mobile/types.go
@@ -49,6 +49,9 @@ type AppMetric struct {
 	// required: true
 	// example: 2.1.0
 	AppVersion string `json:"appVersion"`
+	// required : true
+	// example: cordova
+	Framework string `json:"framework"`
 }
 
 // swagger:model