-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebrand from AIP to AEP. #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toumorokoshi
approved these changes
Oct 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! thanks for doing this.
toumorokoshi
pushed a commit
to toumorokoshi/aep.dev
that referenced
this pull request
Jan 10, 2024
* Rebrand from AIP to AEP. * Rebrand more comprehensively. * Revert change to publish workflow trigger. * Even more rebranding * Temporarily re-enable publishing from this branch. * Disable publishing from this branch again. * Yet another rebranding pass * Fix build-and-publish-protos workflow * Add proto changes I forgot to save, whoops * Revert accidental workflow change
toumorokoshi
pushed a commit
to toumorokoshi/aep.dev
that referenced
this pull request
Jan 24, 2024
* Rebrand from AIP to AEP. * Rebrand more comprehensively. * Revert change to publish workflow trigger. * Even more rebranding * Temporarily re-enable publishing from this branch. * Disable publishing from this branch again. * Yet another rebranding pass * Fix build-and-publish-protos workflow * Add proto changes I forgot to save, whoops * Revert accidental workflow change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Most of) The results of this can already be seen live, because I temporarily changed (and then reverted) the publish workflow to trigger from the
rebrand
branch: http://aep.dev/generalAt least part of this is necessary (renaming files) in order to work with the AEP version of the site generator. Rather than try to figure out exactly what needed to change for that vs. a pure rebrand, I just went ahead and changed all the stuff I could find/think of.