Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a PhoneNumber type based on google.type.PhoneNumber. #3

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

rofrankel
Copy link
Contributor

This PR currently adds a Markdown schema and protobuf implementatiion for phone number.

If the overall schema looks good, I'll add a JSON Schema implementation as well.

@rofrankel rofrankel requested a review from a team as a code owner November 3, 2023 02:54
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high-level comment, the content LGTM.

proto/aep-type/aep/type/phone_number.proto Show resolved Hide resolved
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest I don't see this type being used much - for those who want a phone number and not accept a short code would use a string (which I imagine is many situations, e.g. user accounts).

but for those who need a type with both, this makes sense.

@rofrankel rofrankel merged commit 5fe5673 into main Nov 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants