Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The excludedTypeNames local should not be initialized from the Assemb… #17

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

RobertvanderHulst
Copy link
Contributor

…lyNames property but from the ExcludeTypeNames property

@aelij aelij merged commit 47fbd6e into aelij:main Jan 31, 2024
1 check passed
@aelij
Copy link
Owner

aelij commented Jan 31, 2024

Thanks for the fix!

@BlueAmulet
Copy link

Can we get this pushed to nuget? The version on nuget doesn't contain this fix and you have to specify excludes with additional InternalsAssemblyName statements.

@RobertvanderHulst
Copy link
Contributor Author

RobertvanderHulst commented May 11, 2024

I am sorry, but I gave up using this. The code that I am working with uses too many assemblies with internal types. it was too hard to handle them all.

@BlueAmulet
Copy link

BlueAmulet commented May 11, 2024

You already did you part by fixing the bug, but the fix has been sitting in the repository for months now and no new version has been published to nuget with the fix. That's why I'm asking aelij, the owner.

@RobertvanderHulst
Copy link
Contributor Author

I am sorry, but I gave up using this. The code that I am working with uses too many assemblies with ik internal types. it was too hard to handle them all.

I will look at my code next week and push it and send a pull request.

@BlueAmulet
Copy link

BlueAmulet commented May 11, 2024

??? You literally don't have to do anything. This was the pull request, it was already merged in, the code works, it's just not on nuget. I'm not even asking you to do anything I'm asking aelij, the owner, to just publish a new nuget version.

@RobertvanderHulst
Copy link
Contributor Author

Publishing on nuget must be done by the owner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants