Merge pull request #1039 from aehrc/issue/1036

Fix checkbox open label string input
aehrc · Oct 17, 2024 · 68e0424 · 68e0424
2 parents f4c4ca3 + 2d66fcc
commit 68e0424
Show file tree

Hide file tree

Showing 6 changed files with 22 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,9 @@ This log documents significant changes for the [@aehrc/smart-forms-renderer](htt
 
 Changelog only includes changes from version 0.36.0 onwards.
 
+## [0.44.2] - 2024-10-18
+### Fixed
+- Fixed an issue where inputs in checkbox open-choice's open label field does not update the QuestionnaireResponse. 
 
 ## [0.44.1] - 2024-10-14
 ### Fixed

diff --git a/apps/smart-forms-app/package.json b/apps/smart-forms-app/package.json
@@ -28,7 +28,7 @@
   "dependencies": {
     "@aehrc/sdc-assemble": "^1.3.1",
     "@aehrc/sdc-populate": "^2.3.1",
-    "@aehrc/smart-forms-renderer": "^0.44.1",
+    "@aehrc/smart-forms-renderer": "^0.44.2",
     "@emotion/react": "^11.13.0",
     "@emotion/styled": "^11.13.0",
     "@fontsource/material-icons": "^5.0.18",

diff --git a/documentation/package.json b/documentation/package.json
@@ -15,7 +15,7 @@
     "typecheck": "tsc"
   },
   "dependencies": {
-    "@aehrc/smart-forms-renderer": "^0.44.1",
+    "@aehrc/smart-forms-renderer": "^0.44.2",
     "@docusaurus/core": "^3.4.0",
     "@docusaurus/preset-classic": "^3.4.0",
     "@docusaurus/theme-live-codeblock": "^3.4.0",

diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/smart-forms-renderer/package.json b/packages/smart-forms-renderer/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@aehrc/smart-forms-renderer",
-  "version": "0.44.1",
+  "version": "0.44.2",
   "description": "FHIR Structured Data Captured (SDC) rendering engine for Smart Forms",
   "main": "lib/index.js",
   "scripts": {

diff --git a/packages/smart-forms-renderer/src/utils/openChoice.ts b/packages/smart-forms-renderer/src/utils/openChoice.ts
@@ -106,10 +106,21 @@ export function updateOpenLabelAnswer(
   }
 
   // New open label answer is different from old open label answer, update it
-  oldOpenLabelAnswer.valueString = changedOpenLabelValue;
+  const updatedAnswers = oldQrItem.answer?.map((answer) => {
+    const { valueString } = answer;
+    if (valueString === oldOpenLabelAnswer.valueString) {
+      return {
+        ...answer,
+        valueString: changedOpenLabelValue // Update the valueString
+      };
+    }
+
+    return answer; // Keep the other answers unchanged
+  });
+
   return {
     ...oldQrItem,
-    answer: oldQrItem.answer
+    answer: updatedAnswers
   };
 }