Merge pull request #54 from adzerk/vinodkurup/sc-49262/management-js-…

…sdk-is-requiring-fields-that Updated Spec to Handle Required Values Properly
adzerk · Aug 23, 2023 · 258c4e4 · 258c4e4
2 parents 560d993 + 11af984
commit 258c4e4
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 8 deletions.
diff --git a/management/flight.yaml b/management/flight.yaml
@@ -381,28 +381,30 @@ paths:
                 AttributionClick:
                   type: object
                   nullable: true
+                  required:
+                    - MatchType
+                    - LookbackWindow
                   properties:
                     MatchType:
                       type: string
-                      nullable: false
                       enum: ["SameProduct", "SameCategoryBrand", "SameBrand"]
                     LookbackWindow:
                       type: integer
                       format: int32
-                      nullable: false
                       enum: [1, 7, 14, 30]
                 AttributionView:
                   type: object
                   nullable: true
+                  required:
+                    - MatchType
+                    - LookbackWindow
                   properties:
                     MatchType:
                       type: string
-                      nullable: false
                       enum: ["SameProduct", "SameCategoryBrand", "SameBrand"]
                     LookbackWindow:
                       type: integer
                       format: int32
-                      nullable: false
                       enum: [1, 7, 14, 30]
                 TargetROAS:
                   type: number

diff --git a/management/schemas/flight.yaml b/management/schemas/flight.yaml
@@ -238,25 +238,27 @@ schemas:
       AttributionClick:
         type: object
         nullable: true
+        required:
+          - MatchType
+          - LookbackWindow
         properties:
           MatchType:
             type: string
-            nullable: false
           LookbackWindow:
             type: integer
             format: int32
-            nullable: false
       AttributionView:
         type: object
         nullable: true
+        required:
+          - MatchType
+          - LookbackWindow
         properties:
           MatchType:
             type: string
-            nullable: false
           LookbackWindow:
             type: integer
             format: int32
-            nullable: false
       TargetROAS:
         type: number
         format: float