Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI workflow #226

Closed
wants to merge 3 commits into from
Closed

Conversation

tagliala
Copy link
Contributor

@tagliala tagliala commented Nov 22, 2022

  • Update checkout action to v3. Node.js 12 actions are deprecated
  • Test against Ruby 3.2
  • Test against Ruby and Rails head to detect breaking changes and deprecation
    in advantage. Mark runs as experimental, so they are allowed to fail

@adzap thanks for the release

There is a suggestion on the CI workflow, but if you prefer I can split the experimental checks and schedule them weekly or something like that

@tagliala tagliala changed the title Chore/improve workflows Improve CI workflow Nov 22, 2022
@tagliala
Copy link
Contributor Author

Updated with latest RubyGems and Ruby 3.2

@tagliala tagliala force-pushed the chore/improve-workflows branch 2 times, most recently from a5fe27f to cc0cbf9 Compare May 28, 2023 07:33
- Update checkout action to v3. Node.js 12 actions are deprecated
- Test against Ruby 3.2
- Test against Ruby and Rails head to detect breaking changes and deprecation
  in advantage. Mark runs as experimental, so they are allowed to fail
Use Dependabot to keep GitHub Actions updated
@tagliala
Copy link
Contributor Author

tagliala commented Oct 5, 2023

Updated to test against Rails 7.1 stable

/cc @adzap

Also:
- Set 7.1 as the default Rails in Gemfile
- Do not test Rails edge against Ruby < 3.1 (rails/rails#50491)
@tagliala
Copy link
Contributor Author

tagliala commented Jan 4, 2024

Test against Ruby 3.3 stable

@tagliala
Copy link
Contributor Author

tagliala commented Jan 4, 2024

Need to bisect rails-edge.

Failures depends by #241 , fixed in #242

@tagliala tagliala marked this pull request as draft January 4, 2024 08:59
@tagliala tagliala marked this pull request as ready for review January 4, 2024 16:35
@tagliala tagliala closed this Jan 7, 2024
@tagliala
Copy link
Contributor Author

tagliala commented Jan 7, 2024

Reson for closing:

I've eventually moved to the built-in comparison validator

Relevant changes:

diowa/icare@dd4a467#diff-8f06df7d19040b42d0ab94249895f10fac375834ce5a6f4e55b93570b9dd7d8fL26-R27

@diogonoda
Copy link

hi @tagliala !!!
First of all, thanks for contributing with the project!

There's one feature that I couldn't find in Rails which is the validation on the date type.
For example, if I need to validate an attribute that could be nil:
validates_date :my_date_attribute, allow_blank: true

since Rails will just set my_date_attribute to nil if I try assigning it with String, using validate_timeliness is still valuable to me.
Indeed, Rails comparison will replace some of the features provided by the gem, but not all of them.
That said, I don't see the reason for the EOD of this gem.

Am I missing something here?

@tagliala
Copy link
Contributor Author

That said, I don't see the reason for the EOD of this gem.

It is unmaintained, and the built-in rails validator is ok for most of the use cases

PS: didn't understand the use case, did you check allow_nil ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants