-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CI workflow #226
Improve CI workflow #226
Conversation
Updated with latest RubyGems and Ruby 3.2 |
a5fe27f
to
cc0cbf9
Compare
- Update checkout action to v3. Node.js 12 actions are deprecated - Test against Ruby 3.2 - Test against Ruby and Rails head to detect breaking changes and deprecation in advantage. Mark runs as experimental, so they are allowed to fail
cc0cbf9
to
dce53bb
Compare
Use Dependabot to keep GitHub Actions updated
3806742
to
ca2df92
Compare
Updated to test against Rails 7.1 stable /cc @adzap |
Also: - Set 7.1 as the default Rails in Gemfile - Do not test Rails edge against Ruby < 3.1 (rails/rails#50491)
ca2df92
to
8714624
Compare
Test against Ruby 3.3 stable |
Reson for closing: I've eventually moved to the built-in comparison validator Relevant changes: diowa/icare@dd4a467#diff-8f06df7d19040b42d0ab94249895f10fac375834ce5a6f4e55b93570b9dd7d8fL26-R27 |
hi @tagliala !!! There's one feature that I couldn't find in Rails which is the validation on the date type. since Rails will just set Am I missing something here? |
It is unmaintained, and the built-in rails validator is ok for most of the use cases PS: didn't understand the use case, did you check |
in advantage. Mark runs as experimental, so they are allowed to fail
@adzap thanks for the release
There is a suggestion on the CI workflow, but if you prefer I can split the experimental checks and schedule them weekly or something like that