Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Settings to "Make Web Request" #40

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Change Settings to "Make Web Request" #40

wants to merge 2 commits into from

Conversation

techwithjake
Copy link

Add "TEXT" to "Content Type"

Make "Variables to send" optional

Add "TEXT" to "Content Type"

Make "Variables to send" optional
@ady624
Copy link
Owner

ady624 commented Jul 29, 2016

Made variables optional. What should the content-type be? And how should I encode the body?

@ady624 ady624 reopened this Jul 29, 2016
@techwithjake
Copy link
Author

Still need to work on how to encode the body properly. Part of the reason I closed it out. I had set as just text/plain as the content type but no proper encoding.

Back in line with CoRE master repo from ady624
@ady624
Copy link
Owner

ady624 commented Aug 9, 2016

I cannot merge this because it would not work. There is code that needs to handle the TEXT content-type (text/plain) and I need to know how "TEXT" would encode the body. Some ini-like maybe?

param1=value1
param2=value2
param3=value3

with CRLF between the pairs?

Or should it only be

value1
value2
value3

with CRLF between the values, no parameter names?

I am willing to add the requested feature though :) Let me know, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants