-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with diesel master after 72bfb356 #64
Conversation
Thanks, this is really cool. The README/docs will have to change quite a bit to explain these changes. This is unfortunate as the current instructions on So, I am minded to merge these changes, but then rename the branches like:
I probably should have done that in the first place, but I didn't realise that What you think? |
That makes some sense and wouldn't be at all an issue for me.
Overall I think it's pretty hard to guarantee that the master branch's Readme corresponds to the latest released API so it shouldn't be assumed by the users nor be considered a requirement. |
I'd like to open a separate PR for latest diesel changes. |
Hi sorry my bad, I let this PR dangle way too long. Would you prefer to merge this first before doing a follow-up or just create a new PR with all the changes in it? I should have time to address it this weekend. |
I'd prefer to merge this one first 🙂 |
diesel-rs/diesel#2787 introduced ability for diesel CLI to infer unknown SQL types from the Postgres backend, and generate corresponding SQL types.
This PR aims to support plugging into these auto-generated types from the schema, completely removing the need for patching the diesel schema if using the Postgres backend.
The approach is:
SqlType
structures.