Cross-site scripting (XSS) vulnerability in the password reset endpoint
Moderate severity
GitHub Reviewed
Published
Mar 25, 2021
in
matrix-org/synapse
•
Updated Sep 30, 2024
Description
Reviewed
Mar 26, 2021
Published to the GitHub Advisory Database
Mar 26, 2021
Published by the National Vulnerability Database
Mar 26, 2021
Last updated
Sep 30, 2024
Impact
The password reset endpoint served via Synapse was vulnerable to cross-site scripting (XSS) attacks. The impact depends on the configuration of the domain that Synapse is deployed on, but may allow access to cookies and other browser data, CSRF vulnerabilities, and access to other resources served on the same domain or parent domains.
Patches
This is fixed in #9200.
Workarounds
Depending on the needs and configuration of the homeserver a few options are available:
Password resets can be disabled by delegating email to a third-party service (via the
account_threepid_delegates.email
setting) or disabling email (by not configuring theemail
setting).If the homeserver is not configured to use passwords (via the
password_config.enabled
setting) then the affected endpoint can be blocked at a reverse proxy:/_synapse/client/password_reset/email/submit_token
The
password_reset_confirmation.html
template can be overridden with a custom template that manually escapes the variables using JInja2'sescape
filter. See theemail.template_dir
setting.References