Android: upgrade target SDK to 34 #2655
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This is meant to comply with current Google Play Target SDK requirements. - NDK is kept the same, otherwise we would have to upgrade minSDK from 19 to 21. - We do a few minor upgrades where possible, including the gradlew wrapper version, this causes a few deprecation warnings, but we don't need to act on these yet (and some warnings are from upstream dependencies, so we will just live with them until we can fix all)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to comply with current Google Play Target SDK requirements.
NDK is kept the same, otherwise we would have to upgrade minSDK from 19 to 21.
We do a few minor upgrades where possible, including the gradlew wrapper version, this causes a few deprecation warnings, but we don't need to act on these yet (and some warnings are from upstream dependencies, so we will just live with them until we can fix all)
I am leaving this as draft until it builds and until I have time to test with my physical Android phone.