This repository has been archived by the owner on May 21, 2024. It is now read-only.
httpclient: Always set path to CA certs #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes advancedtelematic#1273 Some versions of OE don't explicitly set a default path to the CA certs directory. This ensures its set and can be overidden if needed. Signed-off-by: Andy Doan <[email protected]>
|
This isn't exactly how we discussed in the bug, but I decided to build off of #1289. It seemed you weren't super excited about that approach, so piling onto the idea might not be the best. |
|
This seems fine to me but I want to make sure there's consensus around that. How do others feel? |
pattivacek
approved these changes
Aug 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1273
Some versions of OE don't explicitly set a default path to the
CA certs directory. This ensures its set and can be overidden if
needed.
Signed-off-by: Andy Doan [email protected]