Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing timestamps #181

Merged
merged 5 commits into from
Apr 26, 2024
Merged

Missing timestamps #181

merged 5 commits into from
Apr 26, 2024

Conversation

femalves
Copy link
Contributor

No description provided.

@femalves femalves requested a review from tjacovich April 19, 2024 16:46
tjacovich
tjacovich requested changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@tjacovich tjacovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one update we might want to make so we don't end up with a lot of duplicate entries in the versions table for the libraries.

biblib/views/library_view.py Outdated Show resolved Hide resolved
tjacovich
tjacovich requested changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@tjacovich tjacovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're nearly there. One last comment on the update logic.

biblib/views/library_view.py Show resolved Hide resolved
tjacovich
tjacovich approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@tjacovich tjacovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Feel free to merge when ready.

@femalves femalves merged commit 3a4a3cb into master Apr 26, 2024
1 check passed
@femalves femalves deleted the missing_timestamps branch April 26, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjacovich tjacovich tjacovich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@femalves @tjacovich