Bugfixes #175
Bugfixes #175
Conversation
biblib/views/user_view.py
Outdated
| @@ -84,6 +84,7 @@ def get_libraries(cls, service_uid, absolute_uid, start=0, rows=None, sort_col=" | |||
| .filter(Permissions.user_id == service_uid)\ | |||
| .order_by(getattr(getattr(Library, sort_col), sort_order)())\ | |||
| .all() | |||
| libraries_response = {'libraries_count': len(result)} | |||
There was a problem hiding this comment.
Moving this because there was another result variable further down. When returning len(result) the output wasn't the expected one.
There was a problem hiding this comment.
That makes sense. It was a good idea to rename the result below to owner_permissions, owner. I don't think you need to break the tuple here, but it might be worth giving this a more descriptive name as well.
biblib/views/user_view.py
Outdated
| @@ -84,6 +84,7 @@ def get_libraries(cls, service_uid, absolute_uid, start=0, rows=None, sort_col=" | |||
| .filter(Permissions.user_id == service_uid)\ | |||
| .order_by(getattr(getattr(Library, sort_col), sort_order)())\ | |||
| .all() | |||
| libraries_response = {'libraries_count': len(result)} | |||
There was a problem hiding this comment.
That makes sense. It was a good idea to rename the result below to owner_permissions, owner. I don't think you need to break the tuple here, but it might be worth giving this a more descriptive name as well.
| if ownership: | ||
| response['my_libraries'] = my_libraries | ||
| response['shared_with_me'] = shared_with_me | ||
| libraries_response['my_libraries'] = my_libraries |
There was a problem hiding this comment.
Giving this a more descriptive name was a good idea for readability.
No description provided.