Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort Library documents by date added #170

Merged
merged 19 commits into from
Oct 25, 2023
Merged

Sort Library documents by date added #170

merged 19 commits into from
Oct 25, 2023

Conversation

tjacovich
Copy link
Contributor

@tjacovich tjacovich commented Jul 27, 2023 •
edited
Loading

  • Added option to sort libraries by date a document was added
    • time asc
    • time desc
  • Set default time for documents already in libraries to 2022/1/1
  • Set default time for documents already in libraries to library creation date.

@tjacovich tjacovich marked this pull request as ready for review July 27, 2023 15:33
@tjacovich tjacovich linked an issue Jul 28, 2023 that may be closed by this pull request
View records by insertion date #140
Closed
kelockhart
kelockhart requested changes Oct 5, 2023
View reviewed changes
Copy link
Member

@kelockhart kelockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments, but one slightly larger issue to consider - what datetime format would be the most flexible here? There's a comment on the code with more details.

alembic/env.py Show resolved Hide resolved
biblib/views/library_view.py Outdated Show resolved Hide resolved
biblib/views/library_view.py Show resolved Hide resolved
biblib/views/library_view.py Show resolved Hide resolved
biblib/views/library_view.py Outdated Show resolved Hide resolved
biblib/models.py Show resolved Hide resolved
kelockhart
kelockhart requested changes Oct 18, 2023
View reviewed changes
Copy link
Member

@kelockhart kelockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A couple minor comments, but nearly done.

alembic/env.py Outdated Show resolved Hide resolved
test.log Outdated Show resolved Hide resolved
biblib/views/library_view.py Outdated Show resolved Hide resolved
biblib/views/library_view.py Outdated Show resolved Hide resolved
kelockhart
kelockhart approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@kelockhart kelockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Merge when ready.

@tjacovich tjacovich merged commit 02ead23 into adsabs:master Oct 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelockhart kelockhart kelockhart approved these changes

Assignees
No one assigned
Labels
DocumentView enhancement GET /libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

View records by insertion date
2 participants
@tjacovich @kelockhart