Skip to content
This repository has been archived by the owner on Jan 14, 2024. It is now read-only.

Commit

Permalink
Update TODO references: #57, #58, #59, #60, #61, #62, #63
Browse files Browse the repository at this point in the history
  • Loading branch information
todo-actions[bot] committed Nov 17, 2019
1 parent 8ec624c commit fe7e20f
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion firestore.rules
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ service cloud.firestore {
match /units/{id}{
allow read, create, delete: if isOwner();
allow update: if isOwner() && userinfoIsValid(request.resource.data);
// TODO [$5dd14fbbf66ebd000711ec59]: check that groups only contain lamps the user has access to.
// TODO [#57]: check that groups only contain lamps the user has access to.
}
match /users/{userId}{
allow read, write: if request.auth.uid == userId;
Expand Down
2 changes: 1 addition & 1 deletion src/App.vue
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export default {
resize(/* event */) {
// hide BottomNav when onscreen keyboard opens (mobile devices)
// only tested on android
// TODO [$5dd14fbbf66ebd000711ec5a]: fix this hack.
// TODO [#58]: fix this hack.
if (
document.activeElement.tagName == "INPUT" &&
this.showBottomNav === undefined
Expand Down
2 changes: 1 addition & 1 deletion src/components/BottomNavigation.vue
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@

<script>
import fabComponent from "@/components/fab.vue";
// TODO [$5dd14fbbf66ebd000711ec5b]: fork vue-fab and allow positioning & text-color
// TODO [#59]: fork vue-fab and allow positioning & text-color
//import fab from 'vue-fab'
export default {
Expand Down
2 changes: 1 addition & 1 deletion src/mixins/localAPI.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export default {
},
mixins: [colorConversion],
beforeCreate() {
// TODO [$5dd14fbbf66ebd000711ec5c]: refactor to VUEX
// TODO [#60]: refactor to VUEX
if (!window.connections) {
window.connections = {};
}
Expand Down
2 changes: 1 addition & 1 deletion src/pages/Control/id.vue
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export default {
methods: {
setActiveTab(state) {
if (typeof state === "string") {
// TODO [$5dd14fbbf66ebd000711ec5d]: refactor this ugly double use of this method.
// TODO [#61]: refactor this ugly double use of this method.
this.activeTab = state;
}
if (typeof state === "object") {
Expand Down
4 changes: 2 additions & 2 deletions src/pages/Settings/id.vue
Original file line number Diff line number Diff line change
Expand Up @@ -120,12 +120,12 @@ export default {
},
methods: {
apply() {
// TODO [$5dd14fbbf66ebd000711ec5e]: save new state
// TODO [#62]: save new state
this.$store.dispatch("units/set", this.unit);
this.$eventHub.$emit("go-back");
},
delete() {
// TODO [$5dd14fbbf66ebd000711ec5f]: save new state
// TODO [#63]: save new state
this.$store.dispatch("units/delete", this.unit.id);
this.$eventHub.$emit("go-back");
},
Expand Down

0 comments on commit fe7e20f

Please sign in to comment.