Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistence for the remote database location + some warnings fixed #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

gkodinov
Copy link

  1. Fixed some javac warnings :
    • .show()-> .setVisible(true
    • .getText()->getPassword()
    • Implemented persistency for remote reporsitory URLs.
      It works similarly to the android version and persists the
      HTTP url, user name and password.
      On startup it checks if there's an URL persisted and if there is
      it overwrites the db file location with the download.

 * .show()-> .setVisible(true
 * .getText()->getPassword()
2. Implemented persistency for remote reporsitory URLs.
   It works similarly to the android version and persists the
   HTTP url, user name and password.
   On startup it checks if there's an URL persisted and if there is
   it overwrites the db file location with the download.
@adrian
Copy link
Owner

adrian commented Feb 23, 2014

Thanks for taking the time to submit this pull request Georgi.

I'm a little confused by the changes related to "persistency for remote reporsitory URL". The remote database URL (and HTTP username/password) is already stored in the database. Does this not work for your requirements?

@gkodinov
Copy link
Author

Hi Adrian,

Thanks for considering my pull request !

On the URL data being stored into the database : huh, that never worked for
me.
I do admit that I haven't inspected this part of the code too.

What I did was the following :

  1. I've created the database as a local one on my laptop (win7 + latest
    JRE).
  2. I uploaded it to my server (together with the .php pages)
  3. I removed the .properties files (as it was pointing to the local file
    that was no longer present)
  4. I then "opened" the remote database from the URL location.
  5. On every restart I had to "re-open" the database (providing the URL, the
    user name and the password), since the data from step renameTo, copy #4 were never
    persisted.
  6. I've tried "Open from URL" on my netbook (win8 there + latest JDK) and
    there it wasn't persisted too. So I had to enter the URL on each restart.
  7. I've got fed up by the url so I decided to put it into the .properties
    file and pick it up in startup :)

Best Regards,
Georgi Kodinov

2014-02-23 18:42 GMT+02:00 Adrian Smith [email protected]:

Thanks for taking the time to submit this pull request Georgi.

I'm a little confused by the changes related to "persistency for remote
reporsitory URL". The remote database URL (and HTTP username/password) is
already stored in the database. Does this not work for your requirements?


Reply to this email directly or view it on GitHubhttps://github.com//pull/25#issuecomment-35835879
.

@adrian
Copy link
Owner

adrian commented Feb 24, 2014

The URL is stored with the database Georgi. What problems did you have getting it to work? I presume you've seen the "Using a HTTP Server" instructions on http://upm.sourceforge.net/upm_swing_userguide.html#database_syncing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants