Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove xcode switch path commands from build scripts #2876

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Haroon-Khel
Copy link
Contributor

Ref https://adoptium.slack.com/archives/C09NW3L2J/p1646743526526249

From the above slack thread, it was determined that a full switch path, /Applications/Xcode.app, can be used for JDK11. Since it is already being used for 8 and 17+, It will be made the default switch path on our build machines via the playbooks (pr incoming). Therefore these commands will not be needed in the build scripts

@Haroon-Khel Haroon-Khel requested review from sxa and gdams March 11, 2022 12:40
@github-actions
Copy link

Thank you for creating a pull request!
If you have not done so already, please familiarise yourself with our Contributing Guidelines and FAQ, even if you have contributed to the Adoptium project before. GitHub actions will now run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

@github-actions github-actions bot added the macos Issues that affect or relate to the MAC OS label Mar 11, 2022
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM But please make sure the default is set correctly on all build machines before this is merged :-)

@Haroon-Khel
Copy link
Contributor Author

Haroon-Khel commented Mar 11, 2022

LGTM But please make sure the default is set correctly on all build machines before this is merged :-)

@sxa Done. And I dont seem to have permissions to merge this. Could you give me permissions, or could you merge this please. Thanks

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jdk8u build

configure: error: Xcode 6, 9-12 is required to build JDK 8, the version found was 13.2.1. Use --with-xcode-path to specify the location of Xcode or make Xcode active by using xcode-select.

@sxa
Copy link
Member

sxa commented Mar 11, 2022

jdk8u build

configure: error: Xcode 6, 9-12 is required to build JDK 8, the version found was 13.2.1. Use --with-xcode-path to specify the location of Xcode or make Xcode active by using xcode-select.

(Adjusted comment) @gdams is the github checks running in a completely differnet environment from the machies we have in jenkins in a way that this doesn't work for? Can we pre-select a default compiler in that environment?

@gdams
Copy link
Member

gdams commented Mar 11, 2022

(Adjusted comment) @gdams is the github checks running in a completely differnet environment from the machies we have in jenkins in a way that this doesn't work for? Can we pre-select a default compiler in that environment?

Yeah I've just pushed a commit

@gdams
Copy link
Member

gdams commented Mar 14, 2022

Looks like the JDK11u build is genuinely broken after switching:

checking size of int *... 0
configure: error: Cannot continue.
configure: The tested number of bits in the target (0) differs from the number of bits expected to be found in the target (64)
configure exiting with result code 1

@Haroon-Khel
Copy link
Contributor Author

@gdams I was able to build jdk11 hotspot on build-macstadium-macos1014-x64-2 using the full xcode-select switch path

bash-3.2$ xcode-select --print-path
/Applications/Xcode.app/Contents/Developer

@Haroon-Khel
Copy link
Contributor Author

Haroon-Khel commented Mar 14, 2022

The build did not hit the same error as the github workflow

checking for stdio.h... (cached) yes
checking size of int *... 8
checking for target address size... 64 bits

@andrew-m-leonard
Copy link
Contributor

this has been stale for over a year, converting to "draft", if no longer needed please close.

@andrew-m-leonard andrew-m-leonard marked this pull request as draft April 3, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macos Issues that affect or relate to the MAC OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants