Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Handling of Arm32 for RHEL & Suse #707

Merged
merged 8 commits into from
Aug 2, 2023

Conversation

steelhead31
Copy link
Contributor

Always translate armv7l into armv7hl for RHEL & Suse release packages, to ensure consistency with artifactory.

@steelhead31 steelhead31 requested a review from sxa August 2, 2023 16:32
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get it shipped :-D

@@ -193,6 +193,9 @@ def jenkinsStepDeb() {
// function handle both Alpine, RedHat and Suse as DISTRO
def jenkinsStepNonDeb(String DISTRO) {
echo "Installer Job for Temurin jdk ${VERSION} - ${ARCH} - ${DISTRO}"
if (("${DISTRO}" == 'RedHat' || "${DISTRO}" == 'Suse') && ("${ARCH}" == 'armv7l')) {
Copy link
Member

@sxa sxa Aug 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The brackets around the ARCH clause seem superfluous, but it won't do any harm ...

@steelhead31 steelhead31 merged commit ebe4b0a into adoptium:master Aug 2, 2023
6 checks passed
@steelhead31 steelhead31 deleted the arm32_fix branch August 2, 2023 17:56
@steelhead31 steelhead31 restored the arm32_fix branch August 2, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants