Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Microsoft installer #692

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Updating Microsoft installer #692

merged 2 commits into from
Jul 24, 2023

Conversation

joe-braley
Copy link
Contributor

Updates Microsoft's JDK11 and JDK17 packages to reflect the latest release.

github-actions[bot]
github-actions bot previously requested changes Jul 19, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

karianna
karianna approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmjaffe37
Copy link
Contributor

jmjaffe37 commented Jul 21, 2023 •
edited
Loading

@joe-braley, can you also add the changes to the debian dependencies to this PR?

In the files from jdk11 and jdk17:

Just change Depends: adoptium-ca-certificates, to Depends: ca-certificates,

@joe-braley
Copy link
Contributor Author

@joe-braley, can you also add the changes to the debian dependencies to this PR?

@jmjaffe37 I believe they have been approved here.

@jmjaffe37
Copy link
Contributor

@joe-braley, oh I didn't see that. Thanks Joe!

@gdams
Copy link
Member

gdams commented Jul 24, 2023

/merge

@github-actions
Copy link

Approval to merge during the lockdown cycle

Please can two Adoptium PMC members comment /approve?

@tellison
Copy link
Contributor

/approve

1 similar comment
@karianna
Copy link
Contributor

/approve

@github-actions github-actions bot dismissed their stale review July 24, 2023 10:26

Thank you @tellison and @karianna for your approvals, this pull request is now approved to merge during release.

@karianna karianna merged commit 8200a2a into adoptium:master Jul 24, 2023
11 checks passed
@joe-braley joe-braley deleted the joe/installerpsu-update branch July 24, 2023 14:18
adamfarley pushed a commit to adamfarley/installer that referenced this pull request Jul 26, 2023
@joe-braley @joebraley @adamfarley
Updating Microsoft installer (adoptium#692)
b711239 
* Update for PSU

* fix spec file loc

---------

Co-authored-by: joebraley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karianna karianna karianna approved these changes

@gdams gdams gdams approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@joe-braley @jmjaffe37 @gdams @tellison @karianna @joebraley