Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MacOS/aarch64 builds to JDK11 pipelines #275

Merged
merged 2 commits into from
Apr 6, 2022
Merged

Conversation

sxa
Copy link
Member

@sxa sxa commented Mar 30, 2022

As discussed in PMC meeting on March 30, 2022.

Draft at the moment as I've been getting hangs when enabling builds with ccache and need to verify it works ok without that. Approvals welcome for the change though :-)

Signed-off-by: Stewart X Addison [email protected]

@github-actions
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), I require an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.

@sxa sxa marked this pull request as draft March 30, 2022 16:37
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sxa
Copy link
Member Author

sxa commented Mar 31, 2022

Wil require adoptium/temurin-build#2885 to be merged before this can build successfully, so please do not merge until that is complete.

@sxa
Copy link
Member Author

sxa commented Apr 6, 2022

I've just merged the other PR so we can now try this

@sxa sxa marked this pull request as ready for review April 6, 2022 15:54
@sxa sxa merged commit ea75761 into adoptium:master Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants