Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exclude JDK23+ openj9 xmac testing on mac10 #5686

Merged
merged 1 commit into from
Oct 15, 2024
Merged

exclude JDK23+ openj9 xmac testing on mac10 #5686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions buildenv/jenkins/openjdk_tests
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,11 @@ timestamps{
LABEL += "&&!sw.os.cent.7"
}

// JDK23+ isn't supported on machines prior to Mac 11 https://github.com/eclipse-openj9/openj9/issues/19694
if (params.JDK_IMPL == "openj9" && PLATFORM == "x86-64_mac" && params.JDK_VERSION && params.JDK_VERSION.toInteger() >= 23) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When this is used with jdknext, is JDK_VERSION "24" or "next"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "next" is a concept only used in the OpenJ9 pipelines. The OpenJ9 pipelines fixed this via https://github.com/eclipse-openj9/openj9/blob/master/buildenv/jenkins/variables/defaults.yml#L391

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but the problem here will be if JDK_VERSION is "next", that toInteger() will throw a NumberFormatException.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, trying it via https://openj9-jenkins.osuosl.org/job/Pipeline-Build-Test-Personal/617/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we will get NumberFormatException when JDK_VERSION = next. I will fix this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But where did "8" come from in a job testing Java 24 (jdknext)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No related problem in that build. Afaik, JDK_VERSION is not set to next.

Copy link
Contributor

@keithc-ca keithc-ca Oct 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It didn't get to that test because PLATFORM == "x86-64_mac" was not true.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://openj9-jenkins.osuosl.org/job/Pipeline-Build-Test-Personal/618/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, with the correct platform we get NumberFormatException

java.lang.NumberFormatException: For input string: "next"
	at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
	at java.base/java.lang.Integer.parseInt(Integer.java:652)
	at java.base/java.lang.Integer.valueOf(Integer.java:983)
	at org.codehaus.groovy.runtime.StringGroovyMethods.toInteger(StringGroovyMethods.java:3319)

LABEL += "&&!sw.os.mac.10"
}

if (params.DOCKER_REQUIRED) {
LABEL += "&&sw.tool.docker"
}
Expand Down