Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openjdk: additional jdk8 hotspot excludes for win32 and arm #5659

Merged

Conversation

zzambers
Copy link
Contributor

Excludes jdk8 failures showing up on linux-arm,windows-x86, see: #5646 (comment)

Testing:
arm_linux: OK
x86-32_windows: OK

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JDK-8209023 status indicates fixed, so we are to presume this will not be fixed for linux-arm ? Approving in any case, but we eventually intend to add automation that will check the status of the issue, and if 'fixed/resolved' will try to automatically reinclude the test and run to verify.

@smlambert smlambert merged commit 3ca1f13 into adoptium:master Oct 1, 2024
3 checks passed
@zzambers
Copy link
Contributor Author

zzambers commented Oct 1, 2024

JDK-8209023 status indicates fixed, so we are to presume this will not be fixed for linux-arm ? Approving in any case, but we eventually intend to add automation that will check the status of the issue, and if 'fixed/resolved' will try to automatically reinclude the test and run to verify.

It was fixed in 12 and backported to 11, but not to 8. I'll probably later propose backport for 8.

@zzambers
Copy link
Contributor Author

zzambers commented Oct 2, 2024

Backport of JDK-8209023 for jdk8: openjdk/jdk8u-dev#590

@zzambers
Copy link
Contributor Author

zzambers commented Oct 2, 2024

Hmm, actually looks like test/compiler/8009761/Test8009761.java was later updated to not require C2 (and therefore to work with Client VM) by: JDK-8048003

I'll backport that as well.

@smlambert
Copy link
Contributor

thanks @zzambers !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants